Fixes #755 - Allow diffing of HTML, head, and body. #756
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
austinkelleher
force-pushed
the
diff-elements
branch
2 times, most recently
from
6f77f4b
to
f1e9a75
Compare
|
I'm not sure doing this is a great idea, but it's probably the least surprising thing to support it. |
It definitely has caused some issues with folks trying marko and it was hard to explain that you need to separate out the page content from the dynamic component content. It's actually nice that the |
austinkelleher
force-pushed
the
diff-elements
branch
from
f1e9a75
to
acb80d2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relies on the following PRs:
patrick-steele-idem/warp10#3
lasso-js/lasso#211