fix: avoid using macro tag #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #34 +/- ##
=======================================
Coverage 95.70% 95.70%
=======================================
Files 6 6
Lines 163 163
Branches 27 27
=======================================
Hits 156 156
Misses 2 2
Partials 5 5 ☔ View full report in Codecov by Sentry. |
DylanPiercey
force-pushed
the
avoid-macro
branch
from
ec6c3b4
to
16653dd
Compare
|
🎉 This PR is included in version 1.9.3 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Using the
<macro>tag recursively while inserting arbitrary html from the micro-frame could cause comments to be inserted in between flushes from the micro-frame if the micro-frame itself was client rendered.This PR switches the implementation to use a recursive tag instead of a macro which shouldn't have this issue.