Updated the regular expressions #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markohlebar
reviewed
Dec 13, 2017
| static let objcImport = ".*#.*(import|include).*[\",<].*[\",>]" | ||
| static let objcModuleImport = ".*@.*(import).*.;" | ||
| static let swiftModuleImport = ".*(import) +.*." | ||
| static let objcImport = "#(import|include).*[\",<].*[\",>]" |
There was a problem hiding this comment.
Hey @clementpadovani, I think this should be #.*(import|include).*[\",<].*[\",>], because one can write
# import "Import.h".
There was a problem hiding this comment.
@markohlebar I updated the regex to be #\s*(import|include).*[\",<].*[\",>] (see 2a8e2c3).
clementpadovani
deleted the
hotfix/make_the_regular_expressions_great_again
branch
This was referenced Dec 30, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This primarily fixes false-positives for properties with
importin their names