Fix inspect getargspec python35 deprecation

[marscher]

fixes
DeprecationWarning: inspect.getargspec() is deprecated, use inspect.signature() instead

[franknoe]

Hm, is this change fully backwards compatible?
Since the sklearn base class is changed - do we still retain full sklearn compatibility with it?

[marscher]

The backported code was written within the Django project to address this problem and has been adopted by SciPy, so yes I guess clever people have written and reviewed it. However the Scikit project offered a much more complicated (and therefore more harder to maintain) solution for the same issue.
So I've chosen the simpler one...

https://github.com/scipy/scipy/pull/5248/files
vs
scikit-learn/scikit-learn#5281 2 PR, 1 introducing the change and already 1 follow up

[franknoe]

Thanks. Since the behavior of the BaseEstimator is unchanged, we should
still be compatible with sklearn.

Am 20/11/15 um 01:55 schrieb Martin K. Scherer:

The backported code was written within the Django project to address
this problem and has been adopted by SciPy, so yes I guess clever
people has written and reviewed it. However the Scikit project offered
a much more complicated (and therefore more harder to maintain)
solution for the same issue.
So I've chosen the simpler one...

https://github.com/scipy/scipy/pull/5248/files
vs
scikit-learn/scikit-learn#5281
scikit-learn/scikit-learn#5281 2 PR, 1
introducing the change and already 1 follow up

—
Reply to this email directly or view it on GitHub
#632 (comment).

---

Prof. Dr. Frank Noe
Head of Computational Molecular Biology group
Freie Universitaet Berlin

Phone: (+49) (0)30 838 75354
Web: research.franknoe.de

Mail: Arnimallee 6, 14195 Berlin, Germany