Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

editor crashed when press Delete key #1366

Closed
1 task done
Jocs opened this issue Sep 24, 2019 · 2 comments · Fixed by #1365
Closed
1 task done

editor crashed when press Delete key #1366

Jocs opened this issue Sep 24, 2019 · 2 comments · Fixed by #1365
Assignees
Labels
🔭 area/muya 🐛 bug Something isn't working 🐞 pri/critical Bugs which cause the Mark Text crash or unable to continue normal use

Comments

@Jocs
Copy link
Member

Jocs commented Sep 24, 2019

Description

  • Can you reproduce the issue?

Steps to reproduce

  1. Create a paragraph with two lines, like bellow:
foo
bar
  1. Put cursor before foo.
  2. Press delete to delete all the content.
  3. Press backspace key, the editor crashed.

Expected behavior:

The editor does not crashed.

Actual behavior:

The editor crashed

Link to an example: [optional]

Versions

  • Mark Text: all
  • Operating system: all
@Jocs Jocs self-assigned this Sep 24, 2019
@Jocs Jocs added 🐣 muya 🐛 bug Something isn't working 🐞 pri/critical Bugs which cause the Mark Text crash or unable to continue normal use labels Sep 24, 2019
@Jocs Jocs mentioned this issue Sep 24, 2019
Jocs pushed a commit that referenced this issue Sep 24, 2019
@fxha
Copy link
Contributor

fxha commented Sep 24, 2019

@Jocs I cannot reproduce this issue.

Jocs added a commit that referenced this issue Sep 25, 2019
* fix: #1336

* fix: #1366
@Jocs
Copy link
Member Author

Jocs commented Sep 25, 2019

@fxha It's due to Delete key did not delete the soft line break after delete all the content. there is still one soft line break left when you click backspace, and it will cause editor crashed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔭 area/muya 🐛 bug Something isn't working 🐞 pri/critical Bugs which cause the Mark Text crash or unable to continue normal use
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants