Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document can't be exported when inline formulas are in other blocks than paragraph #1522

Closed
1 task done
schrej opened this issue Oct 23, 2019 · 1 comment
Closed
1 task done
Assignees
Labels
🔭 area/muya 🐛 bug Something isn't working
Projects

Comments

@schrej
Copy link

schrej commented Oct 23, 2019

Description

Whenever a formula is present in a block that's not a paragraph, e.g. a list or a headline, exporting fails without showing an error.

  • Can you reproduce the issue?

Steps to reproduce

Try to export

# $1+1=2$

Versions

  • Mark Text: 15.1
  • Operating system: macOS 10.15
@fxha fxha added 🐛 bug Something isn't working 🔭 area/muya labels Oct 23, 2019
@fxha
Copy link
Contributor

fxha commented Oct 23, 2019

Thanks for reporting the issue. It's an issue in our markedjs implementation due to a missing function in InlineLexer.

Stack Trace:

TypeError: this.renderer.inlineMath is not a function
Please report this to https://github.com/marktext/marktext/issues.
    at InlineLexer.output (inlineLexer.js?030b:160)
    at Parser.tok (parser.js?ea4c:89)
    at Parser.parse (parser.js?ea4c:36)
    at marked (index.js?b65a:22)
    at ExportHtml.renderHtml (exportHtml.js?dc4f:106)
    at ExportHtml.generate (exportHtml.js?dc4f:167)
    at Muya.exportStyledHTML (index.js?3916:150)
    at VueComponent.handleExport (editor.vue?7b20:900)
    at invokeWithErrorHandling (vue.esm.js?a026:1863)
    at Vue.$emit (vue.esm.js?a026:3891)

@fxha fxha added this to TO-DO in 0.16.0 Oct 23, 2019
@Jocs Jocs self-assigned this Oct 24, 2019
@Jocs Jocs moved this from TO-DO to In Progress in 0.16.0 Oct 26, 2019
Jocs pushed a commit that referenced this issue Oct 26, 2019
@Jocs Jocs moved this from In Progress to Review in 0.16.0 Oct 26, 2019
@Jocs Jocs mentioned this issue Oct 26, 2019
@Jocs Jocs closed this as completed in 8eb5db8 Oct 26, 2019
@Jocs Jocs moved this from Review to Done in 0.16.0 Oct 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔭 area/muya 🐛 bug Something isn't working
Projects
No open projects
0.16.0
  
Done
Development

No branches or pull requests

3 participants