Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The current window is shown as undefined. #1602

Closed
1 task done
31piy opened this issue Nov 4, 2019 · 1 comment
Closed
1 task done

The current window is shown as undefined. #1602

31piy opened this issue Nov 4, 2019 · 1 comment
Labels
🐛 bug Something isn't working
Projects

Comments

@31piy
Copy link

31piy commented Nov 4, 2019

Description

The current opened item is shown as undefined in the Window menu.

  • Can you reproduce the issue?

Steps to reproduce

  1. Open the app.
  2. Open a folder which contains some docs.
  3. Open a doc from the left navbar.
  4. Observe the current doc title is shown in the Window menu.
  5. Close the opened doc.
  6. Observe the current doc title in the Window menu.

Expected behavior:

The item in Window menu should be changed to either of the below:

  1. Mark Text, as it was when the app was opened and no document is opened.
  2. The name of the folder opened.

Actual behavior:

The menu item shows undefined - <folder name>.

Link to an example: [optional]

image

Versions

  • Mark Text: v0.15.1
  • Operating system: MacOS Mojave 10.14.6
@Jocs Jocs added the 🐛 bug Something isn't working label Nov 5, 2019
@Jocs
Copy link
Member

Jocs commented Nov 5, 2019

@31piy Thanks for reporting this bug, PR is also welcomed.

@Jocs Jocs added 🐳 help wanted Extra attention is needed and removed 🐳 help wanted Extra attention is needed labels Nov 5, 2019
@Jocs Jocs added this to Review in 0.16.0 Nov 5, 2019
@Jocs Jocs closed this as completed in a1a91f3 Nov 6, 2019
Jocs added a commit that referenced this issue Nov 6, 2019
fix: #1602 the current window is shown as undefined
@fxha fxha moved this from Review to Done in 0.16.0 Nov 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug Something isn't working
Projects
No open projects
0.16.0
  
Done
Development

No branches or pull requests

2 participants