Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display issues with long text/code block #171

Closed
fxha opened this issue Apr 16, 2018 · 8 comments · Fixed by #1427
Closed

Display issues with long text/code block #171

fxha opened this issue Apr 16, 2018 · 8 comments · Fixed by #1427
Labels
🐛 bug Something isn't working 🎁 Rewarded on Issuehunt This issue has been rewarded on Issuehunt 🐳 help wanted Extra attention is needed

Comments

@fxha
Copy link
Contributor

fxha commented Apr 16, 2018

Issuehunt badges

Description

If you insert a long text into editor, not the complete text is displayed until you click on the text.

Steps to reproduce

  1. create code block and insert a text with let's say min. 30 lines

-- or --

  1. load file/write text with min. 30 lines
  2. set cursor into first line
  3. go to source code mode
  4. if you have "luck", only first lines are shown. If not repeat 2. with another position.

Example text

The second problem only sometimes occurs.

Expected behavior: [What you expected to happen]

Whole text is displayed

Actual behavior: [What actually happened]

mt_hidden_text

Versions

  • Mark Text: v0.9.25/master
  • OS: at least Linux/Windows

IssueHunt Summary

fxha fxha has been rewarded.

Backers (Total: $10.00)

Submitted pull Requests


Tips


IssueHunt has been backed by the following sponsors. Become a sponsor

@Jocs Jocs added 🐛 bug Something isn't working 🐳 help wanted Extra attention is needed labels Apr 17, 2018
@Jocs
Copy link
Member

Jocs commented Apr 17, 2018

@fxha Can you help with this issue at your convenience?

@fxha
Copy link
Contributor Author

fxha commented May 6, 2018

@Jocs Do you have any idea what the problem can be?

@Jocs
Copy link
Member

Jocs commented May 7, 2018

I have not debugged this issue so far, So I have no idea, maybe you need deep into the source code mode and find the reason.

@IssueHuntBot
Copy link

@BoostIO funded this issue with $10. See it on IssueHunt

@hong-duc
Copy link

Hi I am working on this, but I am little stuck now. And if anyone know something, please tell me 😄 thank you.

This is all I know for now:

  1. The bug happen in source code mode
  2. Only do something in the editor (click, press enter or some word, ...etc) it will show the complete text
  3. Console log show that codemirror take all the text, but only render bottom half of it

@hong-duc
Copy link

I dig through codemirror issues and found this #1104
It seem like set

.CodeMirror {
    height: 100%;
}

will solve the issues, but there will be another issues

@Jocs
Copy link
Member

Jocs commented Mar 23, 2019

@hong-duc You can submit a PR as you wish, so that we can test and see if it is feasible.

hong-duc added a commit to hong-duc/marktext that referenced this issue Mar 23, 2019
@hong-duc hong-duc mentioned this issue Mar 23, 2019
@Jocs Jocs closed this as completed in #1427 Oct 2, 2019
@issuehunt-oss
Copy link

issuehunt-oss bot commented Oct 26, 2019

@Jocs has rewarded $7.00 to @fxha. See it on IssueHunt

  • 💰 Total deposit: $10.00
  • 🎉 Repository reward(20%): $2.00
  • 🔧 Service fee(10%): $1.00

@issuehunt-oss issuehunt-oss bot added the 🎁 Rewarded on Issuehunt This issue has been rewarded on Issuehunt label Oct 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug Something isn't working 🎁 Rewarded on Issuehunt This issue has been rewarded on Issuehunt 🐳 help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants