Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jumpClick can't jump to another file #1721

Closed
1 task done
MrHeer opened this issue Nov 18, 2019 · 3 comments
Closed
1 task done

jumpClick can't jump to another file #1721

MrHeer opened this issue Nov 18, 2019 · 3 comments
Labels
🦄 feature request New feature or request

Comments

@MrHeer
Copy link
Contributor

MrHeer commented Nov 18, 2019

Description

  • Can you reproduce the issue?

Steps to reproduce

  1. prepare test1.md and test2.md in the same directory
  2. open test1.md in MarkTest and add [test2](./test2.md)
  3. hover on test2 and you can see the LinkTools
  4. click the second JumpIcon, not work

Expected behavior:

jump to test2.md like CTRL+CLICK

Actual behavior:

nothing

Link to an example: [optional]

Versions

  • Mark Text: develop
  • Operating system: elementary OS 5.0 Juno
@MrHeer
Copy link
Contributor Author

MrHeer commented Nov 18, 2019

Here only deal with the situation start with http

jumpClick: (linkInfo) => {
const { href } = linkInfo
if (href && href.startsWith('http')) {
shell.openExternal(href)
}
},

@MrHeer
Copy link
Contributor Author

MrHeer commented Nov 18, 2019

I want to try fix it, can I PR for this?

@Jocs
Copy link
Member

Jocs commented Nov 19, 2019

@MrHeer Yes, of course, thanks.

@Jocs Jocs added the 🦄 feature request New feature or request label Nov 19, 2019
MrHeer added a commit to MrHeer/marktext that referenced this issue Nov 19, 2019
Jocs pushed a commit that referenced this issue Nov 20, 2019
* Fix jumpClick can't jump to another file (#1721)

* Clean up code
@fxha fxha closed this as completed Nov 20, 2019
ZhuZhengyi pushed a commit to ZhuZhengyi/marktext that referenced this issue Dec 8, 2019
* Fix jumpClick can't jump to another file (marktext#1721)

* Clean up code
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🦄 feature request New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants