Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] add logger and kill process after error #52

Closed
SuperSandro2000 opened this issue Mar 21, 2018 · 5 comments
Closed

[Enhancement] add logger and kill process after error #52

SuperSandro2000 opened this issue Mar 21, 2018 · 5 comments

Comments

@SuperSandro2000
Copy link
Contributor

SuperSandro2000 commented Mar 21, 2018

To better track down errors you should implement a better logger for such crashes and make sure the marktext processes are killed.



I think you need a Windows PC or a good VM.

@Jocs
Copy link
Member

Jocs commented Mar 21, 2018

@SuperSandro2000 AutoSave is still under development, How did this error happen?

@SuperSandro2000
Copy link
Contributor Author

Open MarkText. I will do a PR when I am done with fixing stuff

You should think about adding a proper logger to handle such problems. Unpacking the asar, finding the line and finding something to search for in code is annoying!

@SuperSandro2000
Copy link
Contributor Author

SuperSandro2000 commented Mar 21, 2018

I would be really happy if you may use a different branch for heavily wip stuff that does not compile or work at all and break other stuff. I just wanted to try the other PR if the windows functionality would break and now I need to fix a whole bunch of stuff.

@Jocs and another Bug I found related to this one. The process is not killed after pressing ok. Very annoying too.

#53 fixes 2 of 3 startup crashes
Btw the editor looks a bit off

@SuperSandro2000 SuperSandro2000 changed the title Issues with latest source [Enhancement] add logger and kill process after error Mar 21, 2018
@Jocs
Copy link
Member

Jocs commented Mar 21, 2018

I am still working on auto save and user preferences, I maybe create a dev branch, not push directly to the master.

Jocs added a commit that referenced this issue Mar 21, 2018
@SuperSandro2000
Copy link
Contributor Author

This would be awesome! I think it is always a good practice to keep the master branch at least compilable that the program won't crash on startup.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants