Opti: add loading page when init page #1303
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Illyism
reviewed
Aug 31, 2019
| @@ -17,12 +70,17 @@ | |||
| <% } %> | |||
| </head> | |||
| <body> | |||
| <!-- Initial drag area (for Linux and Windows). --> | |||
| <div id="init-drag-region" style="position: absolute;-webkit-app-region: drag;left: 0;right: 0;top: 0;height: 25px;"></div> | |||
There was a problem hiding this comment.
Add a drag area so that we can drag this app to other place on the screen. but it's no need to use, we add an init loading page to instead it. we can also drag this app when the loading page is shown.
fxha
reviewed
Sep 12, 2019
|
|
||
| #loading-page { | ||
| position: absolute; | ||
| background: #fff; |
There was a problem hiding this comment.
@Jocs Please remove this entry to not overwrite the themes background color. We may forward the special theme color also to the renderer to change the color of the loading animation. Please change this in another PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add loading page when init app.