Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add file encoding support #1438

Merged
merged 2 commits into from
Oct 6, 2019
Merged

Add file encoding support #1438

merged 2 commits into from
Oct 6, 2019

Conversation

fxha
Copy link
Contributor

@fxha fxha commented Oct 3, 2019

Q A
Bug fix? yes
New feature? yes
License MIT

Description

  • Added support for file encoding/decoding and auto guessing file encoding
  • Added default encoding and fixed default end of line character when opening new tabs
  • Added LibreOffice Writer (.odt) pandoc support
  • Fixed settings window background color during loading
  • Updated key bindings documentation

@fxha fxha requested a review from Jocs October 3, 2019 13:31
@Jocs Jocs mentioned this pull request Oct 4, 2019
Merged
@Jocs
Copy link
Member

Jocs commented Oct 4, 2019

@fxha Conflicted.

Jocs
Jocs reviewed Oct 4, 2019
View reviewed changes
src/main/preferences/schema.json Outdated Show resolved Hide resolved
src/main/filesystem/encoding.js Show resolved Hide resolved
@Jocs Jocs merged commit 4a24ff0 into develop Oct 6, 2019
@Jocs Jocs deleted the file-encoding branch October 6, 2019 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jocs Jocs Jocs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@fxha @Jocs