Fix quick open bug and freeze constants to avoid accidental mutation #2323
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
munckymagik
changed the title
munckymagik
changed the title
fxha
approved these changes
Nov 27, 2020
Jocs
added a commit
that referenced
this pull request
Jul 16, 2021
* update readme (#2008) * update readme * remove unused codes * Update third party * remove unused codes * fix: style error in editor setting * Release v0.16.1 (#2011) * Fix typo (#2118) * Include Chocolatey package installation option (#2107) * Update dependencies (#2133) * Fix max width of editor tabs (#2097) * Fix max width of editor tabs * Update sponsor (#2141) * update: sponsors * update img width and height * Add ability to paste images to Features (#2127) * Fix empty shortcuts in shortcut validator (#2130) * Fix Hunspell dictionary downloader on Windows (#2131) * Add missing encoding entry (#2132) * Improve heading font size scaling (#2135) * Reduce dependency bundle size (#2136) * Fix Hunspell spell checker initialization on Windows (#2137) * Disable and hide unnecessary settings options (#2138) * Increase indentation for sidebar treeview (#2161) * Fix image export issues on Windows (#2129) * Fix footnote renderer exception in markedjs (#2162) * Add GitLab math block support (#2119) * update: yarn.lock file (#2178) * feat: switch tabs using alt-#num (#1975) * Fix bad font when exporting document on macOS (#2190) * 📝 update zh_cn.md (#2192) * Improve English grammar in user-interface text. (#2075) * Fix unnecessary character sanitation on clipboard output (#2197) * Fix double used shortcut (#2198) * Fix double used shortcut * Update documentation * Update dependencies (#2199) * Support setting text direction via comand palette (#2194) (#2195) * Update bug issue template (#2215) * Fix inline html renderer (#2224) * Fix sub- and superscript in HTML output * Update dependencies * Conform user-interface text to conventions for trailing punctuation (#2209) * Release v0.16.2 (#2200) Bump version to 0.16.2 and update documentation. * Replace PRC emoji for zh_TW translation with Taiwan flag (#2278) * Update FAQ.md (#2290) Clarify what aidou is for non-chinese users * Fix markdown syntax document mistake for table content align (#2282) (#2296) * Update pt.md (#2350) * Update pt.md My annual contribution to Mark Text, with its documentation accessible to all Brazilians and Portuguese. * Update pt.md * Update pt.md * Update pt.md * Update pt.md * Update pt.md * Update pt.md * Update pt.md * Update pt.md * Update regex of auto link to fix trailing slashes (#2354) * Update FAQ.md - link to Portable (#2337) Fixing link to portable page. * updated turkish translation of readme.md (#2366) * pass file.id to closeTab on middle click (#2272) * Add codeblock highlight and coloration for the SPARQL and Turtle languages (#2365) * fix image paths on readme tr.md (#2374) * Fix issue with not being able to copy table cell (#2375) * fixed issue#2383 (#2397) * Fix quick open bug and freeze constants to avoid accidental mutation (#2323) * fix: #2330 enable shift+tab for table navigation (#2331) * fix: prism language missing while load dependent language (#1752) (#2335) * Fix graphite light wordcount (#2392) * Update dependencies (minor only) (#2402) * fix: typewriter shake after press enter (#1852) * Support negative zoom (#2412) * Restrict export dialog file extensions (#2408) * Allow BCP-47 language codes in spell checker (#2410) * Fix footnote inline code font size (#2411) * feat: add shortcut for toggle-toc (#1863) (#2326) * Make global menu fields mutable (#2407) * Replace text when only one table cell is selected (#2413) * Allow to copy table cells text as plaintext (#2409) * Fix font selection autocomplete (#2420) * Updated korean translation of README.md (#2432) I updated ko.md (korean translation of README.md) to match the latest version of README.md * Rebase markedjs bug fixes (#2419) * Add option to disable HTML rendering (#2414) * Fix symbolic links and related path issues (#2416) * Upgrade to N-API and Electron 11 (#2422) * Upgrade to N-API and Electron 11 * Update Electron and remove workaround * Fix ESLint error * Disble MathML due to DOMPurify security issues (#2436) * Update Simplified Chinese translation of README (#2445) * Improve undo history (#2437) * Add TOC generator to document exporter (#2391) * Add support for relative image directory (#2439) * Fix installation instructions in README.md (#2449) * Update README.md Calling brew cask install is disabled * Update i18n files * Release v0.16.3 (#2448) Co-authored-by: Ran Luo <ransixi@gmail.com> Co-authored-by: saymoon <saymoon@gmail.com> Co-authored-by: shaunmbg <shaunmbg@users.noreply.github.com> Co-authored-by: Micael Dias <diasmicaelandre@gmail.com> Co-authored-by: Dan Dascalescu <ddascalescu+github@gmail.com> Co-authored-by: BeatLink <47278150+BeatLink@users.noreply.github.com> Co-authored-by: He Linming <hlm52pk@163.com> Co-authored-by: Royce <royce2003@qq.com> Co-authored-by: brainchild0 <34869175+brainchild0@users.noreply.github.com> Co-authored-by: Rasmus Eneman <rasmus@eneman.eu> Co-authored-by: nyanpasu64 <nyanpasu64@tuta.io> Co-authored-by: Sbelletier <sbelletier@gmail.com> Co-authored-by: 小新 <xinping.wang@hotmail.com> Co-authored-by: Enderson Menezes <endersonster@gmail.com> Co-authored-by: Sweet Liquid <himejisyana@hotmail.com> Co-authored-by: Nick Ali <1514992+nickali@users.noreply.github.com> Co-authored-by: erentar <erentar2002@gmail.com> Co-authored-by: Max Lantas <mnxndev@outlook.com> Co-authored-by: Vincent Emonet <vincent.emonet@gmail.com> Co-authored-by: Amauri Bizerra <amauriairesfilho@gmail.com> Co-authored-by: Anton Freeman <asfreeman12@gmail.com> Co-authored-by: Dan Munckton <munckfish@gmail.com> Co-authored-by: evan-cohen <evancohen97@gmail.com> Co-authored-by: zmen <sandoverflow@gmail.com> Co-authored-by: bmvisoky <49735648+bmvisoky@users.noreply.github.com> Co-authored-by: YeloMelon <42390003+YeloMelon@users.noreply.github.com> Co-authored-by: MingZZX <41257880+mzzx@users.noreply.github.com> Co-authored-by: カワリミ人形 <kawarimidoll+git@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
QuickOpenCommand._getInclusionswas accidentally mutating theMARKDOWN_INCLUSIONSconstant. So all subsequent searches were adding to the last set of inclusion patterns generated instead of making fresh ones. This made it unusable without restarting the application.Once I fixed this, I wrapped
MARKDOWN_INCLUSIONSand as many other objects that looked like they should be immutable withObject.freeze().This showed up a second accidental mutation of
DEFAULT_TURNDOWN_CONFIG, which I have also fixed.