Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/use picgo to upload image #2890

Merged
merged 9 commits into from
Jan 16, 2022
Merged

Feat/use picgo to upload image #2890

merged 9 commits into from
Jan 16, 2022

Conversation

Jocs
Copy link
Member

@Jocs Jocs commented Jan 15, 2022 •
edited

Q A
Bug fix? no
New feature? yes
Breaking changes? yes
Deprecations? yes
New tests added? not needed
Fixed tickets Fixes #2712 #2460 #2347 #1888
License MIT

Description

  • Use picgo to replace sm.ms, picgo also support github and other image cloud.
  • Move Image Uploader to Image section in preference setting.
  • Fix GitHub uploader faild.

@Jocs Jocs changed the title [WIP] Feat/picgo Feat/use picgo to upload image Jan 15, 2022
@Jocs Jocs requested a review from fxha January 15, 2022 14:52
@Jocs Jocs marked this pull request as ready for review January 15, 2022 14:54
@Jocs Jocs requested a review from fxha January 16, 2022 15:33
fxha
fxha reviewed Jan 16, 2022
View reviewed changes
Copy link
Contributor

@fxha fxha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Jocs Your build fails.

src/renderer/util/fileSystem.js Outdated Show resolved Hide resolved
src/renderer/util/fileSystem.js Outdated Show resolved Hide resolved
@Jocs
Copy link
Member Author

Jocs commented Jan 16, 2022

@Jocs Your build fails.

Fixed.

@Jocs Jocs requested a review from fxha January 16, 2022 16:46
@fxha fxha merged commit 565f475 into develop Jan 16, 2022
@fxha fxha deleted the feat/picgo branch January 16, 2022 17:28
@YalandHong YalandHong mentioned this pull request Jan 21, 2022
Open
@YalandHong YalandHong mentioned this pull request Feb 9, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fxha fxha fxha approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

picGo
2 participants
@Jocs @fxha