Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

samplerCube #22

Closed
pcornier opened this issue Jan 21, 2016 · 17 comments
Closed

samplerCube #22

pcornier opened this issue Jan 21, 2016 · 17 comments

Comments

@pcornier
Copy link

Hi, I tried to play with samplerCube and textureCube() but it seems to stop the rendering. Is it possible to use that type of samplers ? (I'd like to import shaders I made on Shadertoy)

@markusfisch
Copy link
Owner

Hi, sorry, unfortunately not. At the moment, cube textures are not supported. But I will try to add it for the next release.

I'm planning to make the app as compatible as possible to Shadertoy because I want to use their API to import shaders.

@markusfisch
Copy link
Owner

Do you have any preference/idea how you'd want to set/define the six textures for the cube? From a predefined selection (like Shadertoy) or maybe from only one source image (mapping?)? I think it'd be better if a user could create a cube texture from something.

@pcornier
Copy link
Author

I think there is already something called a "vertical cross cube" format that can be used to group six sides of the cube into a single image. You can found examples by searching "vertical cross cube images" on google.

@markusfisch
Copy link
Owner

Okay, that's just what I thought it would be :)

I'll need to think a bit about how to implement that so that a user can create/use/compose textures in that format. Maybe I should just use it as a mask when importing a texture or something like that.

@rafaellago
Copy link

I like the way people made on shdr http://shdr.bkcore.com/ but of course, I have no idea how could this be presented on a small mobile screen.

@markusfisch
Copy link
Owner

Does shdr.bkcore.com support cube textures? Can't find anything. Or did you mean the UI in general?

@rafaellago
Copy link

Ok, I think I misinterpreted things. Thought you were saying about applying shaders to 3d objects.

@pcornier
Copy link
Author

I think you don't have to worry about how users are going to generate their images. You can just print a grid or an unfolded cube on top of the texture preview to show which part will be used.

@markusfisch
Copy link
Owner

Yes, I think so too. I'm going to try that.

@rafaellago: that's a bit further down on the list :)

@pcornier
Copy link
Author

Sounds good, thank you!

@rafaellago
Copy link

@markusfisch no worry, I'm quite pleased with how the app is at the moment. Maybe, camera integration, but since you are trying to make the app shadertoy compatible, I think that soon I'll see the feature.

@markusfisch
Copy link
Owner

Available in 2.4.0, here's a link to the Beta: https://play.google.com/apps/testing/de.markusfisch.android.shadereditor

@markusfisch
Copy link
Owner

Pushed 2.4.0 in production. Should be available in the next few hours.

@pcornier
Copy link
Author

pcornier commented Jun 2, 2016

Oops too late. It works very well, thank you. However, I noticed that clicking the small insert button adds "sampler2D" instead of "samplerCube" but that's not a big issue.

@markusfisch
Copy link
Owner

Oh my :) Will fix this tomorrow. Expect a 2.4.1 very soon. Thanks for reporting!

@fekga
Copy link

fekga commented Jun 2, 2016

Can you add some example cubemap as with the textures? Or give a link where
cubemaps compatible with the editor can be found?
Thanks!

2016-06-02 22:40 GMT+02:00 Markus Fisch notifications@github.com:

Oh my :) Will fix this tomorrow. Expect a 2.4.1 very soon. Thanks for
reporting!


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#22 (comment),
or mute the thread
https://github.com/notifications/unsubscribe/ABpvKHVD7jAXHfP4mecaqYZPsulhuDuvks5qHz-rgaJpZM4HJ6Uo
.

@markusfisch
Copy link
Owner

Yes, that would also make very much sense. I'll try to find (or create) some. Will be in 2.4.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants