Do not start exit_file message with linebreak, add a space at end #66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Since this approach does not work when running tests in parallel, I'll close this PR. Will have a look if this can be incorporated somehow. |
|
Suppress the print in parallel mode? |
|
I think having correct and complete information is too important. And the file runner shall not know whether it is running in parallel or not. Having said that, I think it is possible to get a better printout, regardless of parallel running or not. Just need to find some time to look into it. |
|
Having any luck with this? Or is it "hard" ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I took a quick look at this and it is indeed simple. As you said, users can still stick
\ninto their messages but for me this is much cleaner and more compact. Withness Rcpp with one of the two needed toggles set and the other still complaining at times (and ignore the measurements, I had just run and we now see the very nice effects ofccachepulling down compile times):