Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CREPE incompatible with latest TF #74

Closed
jesseengel opened this issue Apr 6, 2021 · 6 comments
Closed

CREPE incompatible with latest TF #74

jesseengel opened this issue Apr 6, 2021 · 6 comments

Comments

@jesseengel
Copy link

Hi, it seems TF 2.5 will depend on h5py > 3.0 which conflicts with the crepe requirements:

Error message:

The conflict is caused by:
    tensorflow 2.5.0rc0 depends on h5py~=3.1.0
    crepe 0.0.11 depends on h5py<3.0.0 and >=2.7.0

To fix this you could try to:
1. loosen the range of package versions you've specified
2. remove package versions to allow pip attempt to solve the dependency conflict

Any chance we can loosen that?

@jongwook
Copy link
Member

jongwook commented Apr 6, 2021

Hi Jesse, this should be an easy fix; let me check if the model loads fine with h5py >= 3

jongwook added a commit that referenced this issue Apr 6, 2021
* Update h5py requirement to not require 2.x (#74)

* update .travis.yml to install tf 2.4.1

* just to test with tf==2.5.0rc0

* back to tf==2.4.1
@jongwook
Copy link
Member

jongwook commented Apr 6, 2021

It looks like h5py 3.x + tf 2.1 combo is not compatible with the format used for saving the CREPE models, so I had to update the tf version in .travis.yml to 2.4.1 for now. I guess it'll also likely mean CREPE will break for tf 1.x with h5py 3.x, but I guess it should be fine since people can pin to an older version of CREPE and/or h5py.

I'll plan to bump and push a new version before 2.5.0 is out, unless @justinsalamon vetoes?

@jesseengel
Copy link
Author

Thanks Jong Wook! That's super helpful. Whenever you do that, then we can move the ddsp repo to the TF 2.5 release candidates (necessary for a bug fix).

@albertogilramos
Copy link

@jongwook : given tf 2.5 is now out, I was wondering if you're still planing on fixing this. to reproduce the issue on the latest version of tf and ddsp the "Install and import dependencies" in

https://colab.research.google.com/github/magenta/ddsp/blob/main/ddsp/colab/tutorials/0_processor.ipynb

fails with error

ERROR: tensorflow 2.5.0 has requirement h5py~=3.1.0, but you'll have h5py 2.10.0 which is incompatible.

It'd be super helpful if ddsp could run with tf 2.5.

Thank you very much.

@albertogilramos
Copy link

@jongwook : following update of crepe v0.0.12 I can confirm:

Thank you very much.

@Megan8821
Copy link

Megan8821 commented Aug 1, 2022

Hi, when I install crepe-0.0.12, it shows an error about error: metadata-generation-failed and error: subprocess-exited-with-error

In the below code, it shows the certificate error

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants