Skip to content
This repository has been archived by the owner on Apr 17, 2019. It is now read-only.

WIP... which branches for Apollo-2...? #59

Closed
hubert-associates opened this issue Jan 21, 2018 · 3 comments
Closed

WIP... which branches for Apollo-2...? #59

hubert-associates opened this issue Jan 21, 2018 · 3 comments

Comments

@hubert-associates
Copy link

Hi, thanks for this great combination (admin-page on reactjs, material-ui, apollo, graphql). Now, I'm looking to access the latest Apollo-2 cut so I don't re-invent. Precisely which branches should I fetch?

@matseriksen
Copy link

matseriksen commented Jan 21, 2018

The "aor-graphql-client" got updated to Apollo 2 on the master branch 6 days ago.

@hubert-associates
Copy link
Author

hubert-associates commented Jan 22, 2018

I thought still WIP since the package.json still uses apollo-client 1.9.3 there? https://github.com/marmelab/aor-graphql/blob/master/packages/aor-graphql-client/package.json
and the Readme.md doc/examples are still apollo-client 1 as are the samples.
Am I in the wrong branch?

@djhi
Copy link
Collaborator

djhi commented Jan 22, 2018

Well, it has not been updated to use Apollo 2. See #57. It has been updated to accept your own client which can be from Apollo 2. However, this has not been released on npm yet. You can fetch it from the master branch though.

We are in the process of migrating all admin-on-rest projects in the root repository, including those. Work is happening in the next branch. When it will be done, we will migrate our graphql packages to use Apollo 2.

@djhi djhi closed this as completed Jan 22, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants