apollo-client 2.0

[matart15]

Trying to use apollo-client 2 .
Easiest way is pass apollo-client v2 object directly. But this check skips client and builds v1 client.

So, If this v1 client instanceOf check is removed we can use v2 client like this.

import buildApolloClient from 'aor-graphql-client-graphcool'
import ApolloClient from 'apollo-client';
import { HttpLink } from 'apollo-link-http';
import { ApolloLink, concat } from 'apollo-link';

  const client = new ApolloClient({
    link: new HttpLink({ uri: 'http://localhost:3000' }),
    cache: new InMemoryCache().restore(window.__APOLLO_STATE__),
  });

  buildApolloClient({
    client: apolloClient,
  })

[djhi]

I see the problem but we should still be able to pass options and build a client if not specified. It would be better to introduce a new clientOptions parameter. If client is specified, use it, otherwise build one with the clientOptions

[djhi]

I'd rather name this one client and rename the old client to clientOptions. We could then remove completely the check for ApolloClient at L48.

This will be a breaking change though and we need to update the documentation accordingly

[matart15]

OK. I will change it.
But what about tests?

If we need to chage tests I am going to take 1 or 2 days

[djhi]

Can you remove that and just build the ApolloClient if no client was provided already ?

[matart15]

@djhi I cahnged README too. is it ok?

[djhi]

Almost there, you should also mention in the documentation that you can pass an existing client with the client option

[matart15]

It is already mentioned here. https://github.com/marmelab/aor-graphql/blame/master/packages/aor-graphql-client/README.md#L103