Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(test): export class GithubCardSelector #3

Closed
wants to merge 4 commits into from

Conversation

peterennis
Copy link

Closes #2

@peterennis
Copy link
Author

also closes #4

@peterennis
Copy link
Author

@jdemangeon
This is a nice project. Thanks 👍

@jdemangeon
Copy link
Contributor

Hello @peterennis and thanks for your feedback.

The package name of this project don't need to be changed. You're free to fork and use it with this name on your side but not change it in the origin repository.

I'll fix the component definition on my side, thanks a lot ;)

@jdemangeon jdemangeon closed this Jan 6, 2020
@peterennis
Copy link
Author

@jdemangeon

Understood. My bad. I had to create a package to test integration with Stencil
and made a fubar of the PR.

I will make a new clone for doing some I5/A9 integration testing
and will let you know of any issues.

Thanks,

Peter

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

test fail
2 participants