-
Notifications
You must be signed in to change notification settings - Fork 729
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RFR] Add Theming support #192
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fzaninotto
changed the title
[RFR] Add ability to customize template for each view
[WIP] Add ability to customize template for each view
Dec 25, 2014
fzaninotto
changed the title
[WIP] Add ability to customize template for each view
[WIP] Add Theming support
Dec 25, 2014
I thought I needed to edit the link() function of every directive in order to do that, that's why I isolated them first. But it turns out that it wasn't necessary... Anyway, isolating the list column directives was necessary, so now it's done!
Also, moved cssClasses logic to the container of input fields (just like it applies to the container of column fields).
Switching to RFR, will merge shortly if no feedback. |
👍 nice work! Good for me |
This was referenced Dec 28, 2014
Closed
i have var listView = require('./custom-views/listView.html');
admin.customTemplate(function (viewName) {
if (viewName === 'ListView') {
return listView;
}
}); and inside it the problem is, that javascript/ng-admin/Crud/list/list.html cannot be overwriten; <div class="row list-view" ng-class="::'ng-admin-entity-' + listController.entity.name()">
<div class="col-lg-12">
<ma-datagrid name="{{ ::listController.view.name() }}"
entries="listController.dataStore.getEntries(listController.entity.uniqueId)"
selection="selection"
fields="::listController.fields"
list-actions="::listController.listActions"
entity="::listController.entity"
datastore="listController.dataStore">
</ma-datagrid>
</div>
</div>
<div class="row" ng-if="::!listController.infinitePagination">
<div class="col-lg-12">
<ma-datagrid-pagination
page="{{ listController.page }}"
per-page="{{ ::listController.view.perPage() }}"
total-items="{{ listController.totalItems }}"
set-page="::listController.setPageCallback">
</ma-datagrid-pagination>
</div>
</div>
<ma-datagrid-infinite-pagination ng-if="::listController.infinitePagination"
per-page="{{ ::listController.view.perPage() }}"
total-items="{{ ::listController.totalItems }}"
next-page="::listController.nextPageCallback">
</ma-datagrid-infinite-pagination> |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #138, #118, #110.