[RFR] Exclude dependencies during build #333
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| "angular": "~1.3.1", | ||
| "angular": "~1.3.1" | ||
| }, | ||
| "devDependencies": { |
There was a problem hiding this comment.
We'll have to decide which is the default, between ng-admin only and full:
- if ng-admin only, all dependencies below must be
dependencies, because they are required to work with. Developers will need to include them (it can be done automatically in dev with wiredep, that's what Yeoman does) - if full, all dependencies below must be
devDependencies
I think 2 must be for testing purposes only, the target should be 1, and letting the developers do their own build phase.
There was a problem hiding this comment.
It's the full the default one, I've named it ng-admin-only.min.js to not break compatibility.
|
This would be really nice |
manuquentin
force-pushed
the
exlude_dependencies_minification
branch
5 times, most recently
from
e699342
to
f028b79
Compare
manuquentin
changed the title
manuquentin
force-pushed
the
exlude_dependencies_minification
branch
from
f028b79
to
18126ab
Compare
|
Needs rebase |
manuquentin
force-pushed
the
exlude_dependencies_minification
branch
from
18126ab
to
d85f3a5
Compare
|
Needs rebase... again. @jpetitcolas is this PR still necessary now that we aim for webpack? |
|
Superseded by #428 |
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ng-admin-only.min.jsfile without dependenciesRefs #322