fix: Edit identity (primary key) field (#332 issue on GitHub) #334
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -25,6 +25,9 @@ define(function () { | |||
| this.view = view; | |||
| this.entity = this.view.getEntity(); | |||
|
|
|||
| // in case of entity identifier being modified | |||
| this.origEntityId = this.$scope.entry.values[this.entity.identifier().name()] | |||
There was a problem hiding this comment.
I'd use the simpler
this.entityId = entry[this.entity.identifier().name()];
|
Almost all right. I'd just use a better name for the extra parameter - we try to avoid abbreviations in variable names. |
fzaninotto
added a commit
that referenced
this pull request
Mar 18, 2015
fix: Edit identity (primary key) field (#332 issue on GitHub)
|
I did the renaming myself in d02f11c. Thanks for the patch! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was a lot easier than I thought.
Fixed #332
Checked and tested on example configuration.
But all changes to example configuration has been undone.
I've left only patch changes. Is that OK?