[RFR] Fix date sent to json_server in blog example #347
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeromemacias
added a commit
that referenced
this pull request
Mar 5, 2015
[RFR] Fix date sent to json_server in blog example
|
I must be drunk or something: there is no such thing as a date with timezone (only a datetime with time zone). What I added as a special case should be the default case. I'll make another PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We used to send a simple string to the backend, now we send a serialized date. Unfortunately, the backend used in the blog example doesn't understand dates, and even less timezones. So we do the job in the frontend of undoing timezone offset and sending the raw date.
Closes #345