Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RFR] Improve Disabled View Handling #400

Merged
merged 2 commits into from
Apr 15, 2015
Merged

[RFR] Improve Disabled View Handling #400

merged 2 commits into from
Apr 15, 2015

Conversation

fzaninotto
Copy link
Member

  • After creation, redirect to show if edition is disabled (fixes CreationView should redirect to ShowView when EditionView is disabled #393)
  • Do not display the edit button if edition view is disabled
  • Do not display the delete button if deletion view is disabled
  • Use bindOnce as much as possible in views to improve performance
  • Improve routing error handling by displaying the error message on screen and stopping the progress bar
    .

jeromemacias added a commit that referenced this pull request Apr 15, 2015
@jeromemacias
Merge pull request #400 from marmelab/disabled_view
887d4e1 
[RFR] Improve Disabled View Handling
@jeromemacias jeromemacias merged commit 887d4e1 into master Apr 15, 2015
@jeromemacias jeromemacias deleted the disabled_view branch April 15, 2015 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CreationView should redirect to ShowView when EditionView is disabled
2 participants
@fzaninotto @jeromemacias