[RFR] Add label attribute on button directives #407
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| $scope.back = function () { | ||
| $window.history.back(); | ||
| }; | ||
| }, | ||
| template: | ||
| '<a class="btn btn-default" ng-class="size ? \'btn-\' + size : \'\'" ng-click="back()">' + | ||
| '<span class="glyphicon glyphicon-chevron-left" aria-hidden="true"></span> Back' + | ||
| '<span class="glyphicon glyphicon-chevron-left" aria-hidden="true"></span> {{ label }}' + |
There was a problem hiding this comment.
Use {{ ::label }} to reduce overhead (one-time binding). Same for each directive in the PR.
|
Can you add an entry about label into the Readme ? |
fzaninotto
added a commit
that referenced
this pull request
Apr 30, 2015
[RFR] Add label attribute on button directives
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
maFilteredListButtonDirectivealready had atextattribute for that. I've renamed it tolabelfor more consistency.