Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RFR] Fix button display when a view is disabled #449

Merged
merged 3 commits into from
May 20, 2015
Merged

[RFR] Fix button display when a view is disabled #449

merged 3 commits into from
May 20, 2015

Conversation

manuquentin
Copy link
Contributor

Refs #447

  • Add missing condition to hide buttons
  • Disable views by default (except deleteView)
  • Use the number of fields to know if a view is enabled

@jeromemacias
Copy link
Contributor

It will be a BC break, no ?

@manuquentin
Copy link
Contributor Author

Not really, it break things that with weird behaviour.
Like ListView without fields of MenuView for an entity without ListView.

jeromemacias added a commit that referenced this pull request May 20, 2015
@jeromemacias
Merge pull request #449 from marmelab/list_buttons_without_listview
a2ea0ec 
[RFR] Fix button display when a view is disabled
@jeromemacias jeromemacias merged commit a2ea0ec into master May 20, 2015
@jeromemacias jeromemacias deleted the list_buttons_without_listview branch May 20, 2015 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@manuquentin @jeromemacias