Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RFR] Fix dashboard not retrieve entity references #488

Merged
merged 2 commits into from
Jun 3, 2015
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
59 changes: 57 additions & 2 deletions src/javascripts/ng-admin/Main/component/service/PanelBuilder.js
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,62 @@ PanelBuilder.prototype.getPanelsData = function (sortField, sortDir) {
dashboardSortField = sortField;
dashboardSortDir = sortDir;
}
promises.push(self.ReadQueries.getAll(dashboardView, 1, {}, dashboardSortField, dashboardSortDir));
promises.push((function (dashboardView, dashboardSortField, dashboardSortDir) {
var rawEntries, nonOptimizedReferencedData, optimizedReferencedData;

return self.ReadQueries
.getAll(dashboardView, 1, {}, dashboardSortField, dashboardSortDir)
.then(function (response) {
rawEntries = response.data;

return rawEntries;
})
.then(function (rawEntries) {
return self.ReadQueries.getFilteredReferenceData(dashboardView.getNonOptimizedReferences(), rawEntries);
})
.then(function (nonOptimizedReference) {
nonOptimizedReferencedData = nonOptimizedReference;

return self.ReadQueries.getOptimizedReferencedData(dashboardView.getOptimizedReferences(), rawEntries);
})
.then(function (optimizedReference) {
optimizedReferencedData = optimizedReference;

var references = dashboardView.getReferences(),
referencedData = angular.extend(nonOptimizedReferencedData, optimizedReferencedData),
referencedEntries;

for (var name in referencedData) {
referencedEntries = dataStore.mapEntries(
references[name].targetEntity().name(),
references[name].targetEntity().identifier(),
[references[name].targetField()],
referencedData[name]
);

dataStore.setEntries(
references[name].targetEntity().uniqueId + '_values',
referencedEntries
);
}
})
.then(function () {
var entries = dataStore.mapEntries(
dashboardView.entity.name(),
dashboardView.identifier(),
dashboardView.getFields(),
rawEntries
);


// shortcut to diplay collection of entry with included referenced values
dataStore.fillReferencesValuesFromCollection(entries, dashboardView.getReferences(), true);

return {
entries: entries
};
});
})(dashboardView, dashboardSortField, dashboardSortDir));
}

return this.$q.all(promises).then(function (responses) {
Expand All @@ -59,7 +114,7 @@ PanelBuilder.prototype.getPanelsData = function (sortField, sortDir) {
fields: fields,
entity: entity,
perPage: view.perPage(),
entries: dataStore.mapEntries(entity.name(), entity.identifier(), fields, response.data),
entries: response.entries,
sortField: view.getSortFieldName(),
sortDir: view.sortDir()
});
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ describe("PanelBuilder", function () {
describe('getPanelsData', function() {

it('should retrieve panels', function (done) {
var entity = new Entity(),
var entity = new Entity('myEntity'),
view1 = new DashboardView('view1')
.title('dashboard1')
.setEntity(entity)
Expand Down Expand Up @@ -84,8 +84,15 @@ function getPanelBuilder(dashboardViews, responses) {
}
};
};
var retrieveQueries = { getAll: function() {} };
var location = { search: function() { return {}; } };
var readQueries = {
getAll: function() {
return mixins.buildPromise({ data: [] });
},
getFilteredReferenceData: function() { return {}; },
getOptimizedReferencedData: function() { return {}; }
};
var AdminDescription = { getDataStore: function() { return new DataStore(); } };

return new PanelBuilder(q, retrieveQueries, Configuration, AdminDescription);
return new PanelBuilder(q, readQueries, Configuration, AdminDescription);
}