[RFR] Revamp Filter UX #522
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 24, 2015
fzaninotto
force-pushed
the
filter_ui
branch
3 times, most recently
from
9f0befa
to
e976e8b
Compare
|
Switching to RFR |
|
Needs rebase |
| this.$scope.values = this.$scope.values() || {}; | ||
| $scope.$watch('values', (newValues, oldValues) => { | ||
| if (newValues != oldValues) { | ||
| this.filter(); // FIXME use debounce |
There was a problem hiding this comment.
I know, will do in a future PR. Call me technical debt.
|
👍 |
|
Code review applied |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix boolean filter (should display as text - hidden input?)(to be done in another PR)