Merge pull request #7 from marmelab/fix_missing_params

[RFR] Fix missing params check
marmelab · Oct 6, 2014 · 860b1c3 · 860b1c3
2 parents ecc33a0 + c85d64c
commit 860b1c3
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 5 deletions.
diff --git a/src/PHPCRAPI/Silex/Controller/NodeController.php b/src/PHPCRAPI/Silex/Controller/NodeController.php
@@ -43,11 +43,11 @@ public function addNodePropertyAction(SessionManager $repository, $workspace, $p
         $name  = $request->request->get('name');
         $value = $request->request->get('value');
 
-        if (!$name || !$value) {
+        if ($name === null || $value === null) {
             $this->app->abort(400, 'Missing parameters');
         }
 
-        $type  = $request->request->get('type',null);
+        $type  = $request->request->get('type', null);
         $properties = $currentNode->getPropertiesAsArray();
 
         if (array_key_exists($name, $properties) && is_array($properties[$name]['value'])) {
@@ -77,7 +77,7 @@ public function updateNodeAction(SessionManager $repository, $workspace, $path,
 
         $currentNode = $repository->getNode($path);
 
-        if (!$method = $request->request->get('method')) {
+        if (($method = $request->request->get('method')) === null) {
             $this->app->abort(400, 'Missing parameters');
         }
 
@@ -131,7 +131,7 @@ public function addNodeAction(SessionManager $repository, $workspace, $path, Req
 
         $currentNode = $repository->getNode($path);
 
-        if (!$relPath = $request->request->get('relPath')) {
+        if (($relPath = $request->request->get('relPath')) === null) {
             $this->app->abort(400, 'Missing parameters');
         }
 

diff --git a/src/PHPCRAPI/Silex/Controller/WorkspaceController.php b/src/PHPCRAPI/Silex/Controller/WorkspaceController.php
@@ -34,7 +34,7 @@ public function getWorkspaceAction(SessionManager $repository, $workspace)
 
     public function createWorkspaceAction(SessionManager $repository, Request $request)
     {
-        if (!$name = $request->request->get('name')) {
+        if (($name = $request->request->get('name')) === null) {
             $this->app->abort(400, 'Missing parameters');
         }