Merge pull request #7682 from Andonyaa/fix-text-input-bug

Fixing textinput changing 'on' into 'false'
marmelab · May 17, 2022 · 05edc2a · 05edc2a
2 parents 55e54a9 + acafd38
commit 05edc2a
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 3 deletions.
diff --git a/packages/ra-core/src/form/useInput.ts b/packages/ra-core/src/form/useInput.ts
@@ -97,8 +97,8 @@ export const useInput = (props: InputProps): UseInputValue => {
             if (onChange) {
                 onChange(...event);
             }
-            const eventOrValue = (typeof event[0]?.target?.checked ===
-                'boolean' && event[0]?.target?.value === 'on'
+            const eventOrValue = (props.type === 'checkbox' &&
+            event[0]?.target?.value === 'on'
                 ? event[0].target.checked
                 : event[0]?.target?.value ?? event[0]) as any;
             controllerField.onChange(
@@ -132,6 +132,7 @@ export type InputProps<ValueType = any> = Omit<
         onBlur?: (...event: any[]) => void;
         onChange?: (...event: any[]) => void;
         parse?: (value: any) => ValueType;
+        type?: string;
         resource?: string;
         source: string;
         validate?: Validator | Validator[];

diff --git a/packages/ra-ui-materialui/src/input/NumberInput.tsx b/packages/ra-ui-materialui/src/input/NumberInput.tsx
@@ -161,7 +161,12 @@ export interface NumberInputProps
     extends CommonInputProps,
         Omit<
             TextFieldProps,
-            'label' | 'helperText' | 'defaultValue' | 'onChange' | 'onBlur'
+            | 'label'
+            | 'helperText'
+            | 'defaultValue'
+            | 'onChange'
+            | 'onBlur'
+            | 'type'
         > {
     step?: string | number;
     min?: string | number;