Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix <TextInput> changes 'on' into 'false' #7682

Merged
merged 3 commits into from
May 17, 2022

Conversation

Andonyaa
Copy link

Hello,
I came across a bizarre issue while implementing the last version of react-admin. Indeed, if the content of a any Input containing text is "on" it will be replaced by "false" (the bug was case sensitive, it can be verified on the demo login page for example).
I tried and fixed it in my personal repository, so i'm submitting this pull request to help other encoutering this issue.

Copy link
Contributor

@slax57 slax57 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch! Thanks!
I'll just wait for other reviewers to confirm they too agree with the fix you chose

@djhi djhi added this to the 4.0.5 milestone May 17, 2022
Copy link
Contributor

@djhi djhi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@djhi djhi merged commit 05edc2a into marmelab:master May 17, 2022
@fzaninotto fzaninotto changed the title Fixing textinput changing 'on' into 'false' Fix <TextInput> changes 'on' into 'false' May 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants