Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RFR] Add error prop to FormHelperText, to mark it as error on error meta #2335

Merged
merged 1 commit into from
Sep 19, 2018
Merged

[RFR] Add error prop to FormHelperText, to mark it as error on error meta #2335

merged 1 commit into from
Sep 19, 2018

Conversation

natrim
Copy link
Contributor

@natrim natrim commented Sep 19, 2018

Add's error prop to FormHelperText, to mark it as error on error meta

Makes the error text red (well, the error color defined by theme) like other errors in TextInput's

changes RichTextInput, RadioButtonGroupInput, CheckboxGroupInput and SelectArrayInput

note: added as pull to master instead of next as i consider it a bug that these components have inconsistent way to display error with other input's

edit: maybe i should add some borderBottom to make it even more consistent?
edit2: added images

before:
old

old

after (in this PR):
new

new

with borderBottom (not in this PR, shpuld i add it?):
withborder

withborder

@fzaninotto
Copy link
Member

Nice! I don't think the border bottom is necessary in the Boolean input.

But this is a new feature, so as per our release policy, it must be PRed against the next branch rather than the master branch. Can you please rebase and repush?

@fzaninotto fzaninotto added this to the 2.4.0 milestone Sep 19, 2018
@natrim natrim changed the base branch from master to next September 19, 2018 13:40
@natrim
Copy link
Contributor Author

natrim commented Sep 19, 2018

@fzaninotto rebased on next

and btw this PR has nothing to do with Boolean input ? (the radios are RadioButtonGroupInput)

@fzaninotto
Copy link
Member

Sorry, you're right, I meant RadioButtonGroupInput.

@fzaninotto fzaninotto merged commit 6227e46 into marmelab:next Sep 19, 2018
@fzaninotto
Copy link
Member

Thanks!

@natrim natrim deleted the FormHelperText-Error branch September 3, 2019 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants