[RFR] Custom User Menu icon #2391
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djhi
requested changes
Oct 5, 2018
| if (!logout && !children) return null; | ||
| const { anchorEl } = this.state; | ||
| const open = Boolean(anchorEl); | ||
|
|
||
| const menuIconProps = { | ||
| 'arial-label': label && translate(label, { _: label }), |
There was a problem hiding this comment.
We should provide a default label too imo. Something like Profile ?
There was a problem hiding this comment.
Currently there is a default label used as default prop: ra.auth.user_menu.
djhi
approved these changes
Oct 5, 2018
fzaninotto
requested changes
Oct 9, 2018
|
By custom icon you mean remove the possibility to change the node and keep only the overriding of the icon prop by another icon from material-ui? |
fzaninotto
reviewed
Oct 10, 2018
| if (!logout && !children) return null; | ||
| const { anchorEl } = this.state; | ||
| const open = Boolean(anchorEl); | ||
|
|
||
| const menuIconProps = { |
There was a problem hiding this comment.
I don't need you need to extract the props now that only the icon prop is accepted.
fzaninotto
approved these changes
Oct 11, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The idea is to let the user choosing the Icon but also the Component without rewriting the whole UserMenu.
Todo
Screenshots
Changing UserMenu icon
Changing UserMenu component