-
-
Notifications
You must be signed in to change notification settings - Fork 5.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed wrong scalar types into variables for ra-data-graphql-simple #3036
Conversation
Sorry, the tests are currently a PITA to maintain. I'll have to clear some of them. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Can you please run prettier on this file? There is a make command for it, and a yarn one if you can't run make
@djhi Also, I fixed a little bug for it |
Ok, I'll do it now |
Btw, I'm afraid this will be a breaking change for those who haven't upgraded their graphql package. Can you confirm ? |
@djhi It works well for me. I tested it with graphql@0.13.2 and graphql@14.1.1 . The update related only with scalar values coercion to correctly types. Started from version 14.0.0 graphQL server throws an error if the client sends in variables wrong type. For example on the server args:
And the client sends:
It will work before version 14.0.0, but started from version 14.0.0 the server will return error "wrong type". Just need to complete tests with green result :-) |
It will works for old GraphQL packages too |
…ildVariables, ra-data-graphql-simple
Thanks! |
The fix for GraphQL version 14.0.0+ related scalar value coercion. The current version doesn't work correctly. GraphQL changes: https://www.libupdate.com/libs/1c88bd1e-024d-41aa-9241-c29cd6d5f0c5