Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AutocompleteArrayInput] wrap chips instead of increasing view width #3131

Merged

Conversation

cherniavskii
Copy link
Contributor

When using AutocompleteArrayInput with lots of chips, view gets wider and wider.
This PR enables chips wrapping to avoid this problem.

Before:
Screenshot 2019-04-16 at 15 51 39

After:
Screenshot 2019-04-16 at 15 53 50

@djhi
Copy link
Contributor

djhi commented Apr 19, 2019

This one will take a bit longer to be approved as we have to test it on multiple browser using browserstack first

@cherniavskii
Copy link
Contributor Author

@djhi Sure, thanks for looking into this

@fzaninotto
Copy link
Member

I tested it successfully on Chrome Ubuntu, Firefox Ubuntu, Safari MacOS, Edge Windows 10, Chrome Windows 10, Chrome Android. Good to merge!

@fzaninotto fzaninotto merged commit cb6b294 into marmelab:master Apr 25, 2019
@fzaninotto
Copy link
Member

Thanks!

@fzaninotto fzaninotto added this to the 2.9.0 milestone Apr 25, 2019
@cherniavskii cherniavskii deleted the AutocompleteArrayInput-wrapping branch April 25, 2019 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants