Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RFR] Ensure List Data Update when Default Filters Change #3308

Merged
merged 6 commits into from
Aug 5, 2019

Conversation

djhi
Copy link
Contributor

@djhi djhi commented Jun 5, 2019

Fix #3132
Supersedes #3251

@djhi djhi added this to the v2.9.3 milestone Jun 5, 2019
@djhi djhi requested a review from fzaninotto June 5, 2019 10:22
@djhi djhi changed the title Ensure List Data Update when Default Filters Change [RFR] Ensure List Data Update when Default Filters Change Jun 5, 2019
@djhi
Copy link
Contributor Author

djhi commented Jun 5, 2019

@tarnowsc Thanks for trying to fix this issue 👍 While reviewing your pull request, I noticed opportunities to simplify our code and fix the issue which is why I created another pr.

@fzaninotto fzaninotto removed this from the v2.9.3 milestone Jun 13, 2019
@agnsier
Copy link

agnsier commented Jun 26, 2019

Hi, any progress on that pull request? Could you tell me when do you plan to release a new version with that fix?

Thanks!

@manuelamaria
Copy link

Hi guys, thanks for looking into this reported issue. This functionality became very important for our project. Is there any chance this PR might get merged soon? I've been trying to find a workaround with no success.

Thank you!

@agnsier
Copy link

agnsier commented Aug 2, 2019

Hi guys, thanks for looking into this reported issue. This functionality became very important for our project. Is there any chance this PR might get merged soon? I've been trying to find a workaround with no success.

Thank you!

We also had a problem with that permanent filter in our project. In our case, we added a key property for a List component. That helped :)
Example:
<List {...props} filters={<CustomFilters />} exporter={false} key={props.filter.customFilter}><CustomDatagrid/> </List>

This {props.filter.customFilter} came from react-router Route component.

Good luck :)

@Kmaschta Kmaschta added this to the 2.9.6 milestone Aug 5, 2019
@Kmaschta Kmaschta merged commit 4a0fbd2 into master Aug 5, 2019
@Kmaschta Kmaschta deleted the fix-list-permanent-filters branch August 5, 2019 08:53
@manuelamaria
Copy link

Great! Thanks a lot!

Thanks to you @agnsier also, for your suggestion.

@djhi
Copy link
Contributor Author

djhi commented Aug 5, 2019

Please not it has not been released yet though and won't be before a few weeks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Permanent filter mapped to state value doesn't filter correctly
5 participants