[RFR] Upgrade react-redux to version 7.1 #3349
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Requires changes in useSelector due to breaking change in react-redux 7.1.0-alpha.5 (see https://github.com/reduxjs/react-redux/releases/tag/v7.1.0-alpha.5).
djhi
reviewed
Jun 20, 2019
| @@ -19,7 +19,7 @@ | |||
| "react-admin": "^2.0.0", | |||
| "react-app-polyfill": "^0.1.3", | |||
| "react-dom": "~16.8.0", | |||
| "react-redux": "^7.1.0-rc.1", | |||
| "react-redux": "^7.1.0", | |||
There was a problem hiding this comment.
Shouldn't we remove this line as ra-core already includes it as a dependency (not a peer)?
There was a problem hiding this comment.
No, because some components in ra-ui-material-ui use useDispatch and useSelector directly.
There was a problem hiding this comment.
And ? ra-ui-material also depends on ra-core
There was a problem hiding this comment.
Right, but we have to be explicit about our dependencies. If ra-ui-material-ui imports functions from recat-router, it must have react-router in dependencies. I didn't invent that rule, it's enforced by TypeScript I think.
Also, this PR doesn't change anything regarding new dependencies - it just upgrades them.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires changes in useSelector due to breaking change in react-redux 7.1.0-alpha.5 (see https://github.com/reduxjs/react-redux/releases/tag/v7.1.0-alpha.5).
Without this upgrade, TypeScript will fail to build after a yarn fresh install, because the new DefinitelyTyped types for react-redux enforce the
useSelectorsignature of 7.1.0 final.