Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RFR] Replace withStyles with useStyles #3485

Merged
merged 5 commits into from
Aug 8, 2019
Merged

[RFR] Replace withStyles with useStyles #3485

merged 5 commits into from
Aug 8, 2019

Conversation

m4theushw
Copy link
Contributor

@m4theushw m4theushw commented Aug 3, 2019 •
edited
Loading

Refs #3453

This PR converts the remaining components from #3461.

  • ra-ui-materialui/src/auth/Login.tsx
  • ra-ui-materialui/src/layout/Notification.js

djhi
djhi requested changes Aug 5, 2019
View reviewed changes
Copy link
Contributor

@djhi djhi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this 👍

packages/ra-ui-materialui/src/auth/Login.tsx Outdated Show resolved Hide resolved
packages/ra-ui-materialui/src/auth/Login.tsx Outdated Show resolved Hide resolved
packages/ra-ui-materialui/src/layout/Notification.tsx Outdated Show resolved Hide resolved
packages/ra-ui-materialui/src/layout/Notification.tsx Outdated Show resolved Hide resolved
packages/ra-ui-materialui/src/layout/Notification.tsx Outdated Show resolved Hide resolved
packages/ra-ui-materialui/src/layout/Notification.tsx Outdated Show resolved Hide resolved
@djhi
Copy link
Contributor

djhi commented Aug 5, 2019

As I explained in #3461, I'm going to change all inputs for react-final-form migration. I will update them to use makeStyle at the same time. You should omit them to avoid conflicts later

@Kunnu01
Copy link
Contributor

Kunnu01 commented Aug 7, 2019

Can I work on the remaining components ( BulkActions, Layout )?

@m4theushw
Copy link
Contributor Author

@Kunnu01 yes, of course. I will change the PR to RFR.

@m4theushw m4theushw changed the title [WIP] Replace withStyles with useStyles [RFR] Replace withStyles with useStyles Aug 7, 2019
djhi
djhi requested changes Aug 7, 2019
View reviewed changes
Copy link
Contributor

@djhi djhi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Good job 👍

packages/ra-ui-materialui/src/layout/Notification.tsx Outdated Show resolved Hide resolved
djhi
djhi approved these changes Aug 8, 2019
View reviewed changes
Copy link
Contributor

@djhi djhi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💪

@djhi djhi added this to the 3.0.0 milestone Aug 8, 2019
@djhi djhi merged commit ce6db61 into marmelab:next Aug 8, 2019
@djhi
Copy link
Contributor

djhi commented Aug 8, 2019

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djhi djhi djhi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@m4theushw @djhi @Kunnu01