[RFR] Refactor withStyles to useStyles for 10 components #3546
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaytula
changed the title
jaytula
changed the title
jaytula
changed the title
fzaninotto
requested changes
Aug 20, 2019
CreateButton, FormInput, ToolBar, Labeled, RadioButtonGroupInput, NotFound, BulkActionsToolbar, DatagridHeaderCell, DatagridLoading, SimpleList
Remove createStyles Add classes prop to allow overrides Remove enhance where only one HOC and just inline it
jaytula
force-pushed
the
next-withstyles-to-makestyles
branch
from
f147ada
to
7e12a00
Compare
|
I've made requested changes. Thank you again for reviewing and providing instructive advice on how to fix the shortcomings. Looking forward to a re-review. Thanks! |
fzaninotto
approved these changes
Aug 21, 2019
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactored components are: CreateButton, FormInput, ToolBar, Labeled, RadioButtonGroupInput, NotFound, BulkActionsToolbar, DatagridHeaderCell, DatagridLoading, SimpleList
This is for issue #3453 .