[RFR] New ra-tree for react-admin v2 #3771
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
djhi
commented
Oct 3, 2019
•
djhi
commented
- Refactor according to feedbacks
- Actions on nodes
- Add drag & drop with reordering
- Optimistic updates
- Optimistic updates for react-admin actions
- Adding new nodes
- Tests
- Documentation
djhi
changed the title
djhi
commented
Oct 15, 2019
fzaninotto
requested changes
Oct 15, 2019
| ...rest | ||
| }) => ( | ||
| <Toolbar className={classes.toolbar}> | ||
| <span /> |
There was a problem hiding this comment.
I understand you're using justifyContent: 'space-between' and this span to push the actions to the right. But that means that 90% of the line is the toolbar... Wrong solution IMHO.
There was a problem hiding this comment.
That's how it is done in the ListToolbar from which I just removed the filters
| @@ -0,0 +1,538 @@ | |||
| import React, { | |||
There was a problem hiding this comment.
this file needs to be split into several smaller components, it's too hard to follow
Co-Authored-By: Francois Zaninotto <francois@marmelab.com>
Co-Authored-By: Francois Zaninotto <francois@marmelab.com>
Co-Authored-By: Francois Zaninotto <francois@marmelab.com>
Co-Authored-By: Francois Zaninotto <francois@marmelab.com>
Co-Authored-By: Francois Zaninotto <francois@marmelab.com>
Co-Authored-By: Francois Zaninotto <francois@marmelab.com>
Closed
fzaninotto
approved these changes
Oct 18, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.