[RFR] Fix SelectInput variant="standard" shows warning for unknown class #3988
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djhi
reviewed
Nov 15, 2019
| @@ -95,7 +95,10 @@ function ResettableTextField({ | |||
| classes={restClasses} | |||
| value={value} | |||
| InputProps={{ | |||
| classes: { adornedEnd: props.select ? inputAdornedEnd : null }, | |||
| classes: | |||
| props.select && variant === 'filled' | |||
There was a problem hiding this comment.
I don't get the fix. Why is it needed to check the variant ?
There was a problem hiding this comment.
Because the inputAdornedEnd class doesn't exist in the standard variant of MUI's TextField. Unfortunately, the list of classes of all variants isn't the same, hence the warning that we have to fix.
djhi
approved these changes
Nov 15, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3987