Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] eslint version dependency #4411

Closed
wants to merge 11 commits into from
Closed

Conversation

bestori
Copy link

@bestori bestori commented Feb 11, 2020

Demo and tutorial would not run unless this dependency version is updated.

@fzaninotto
Copy link
Member

The build fails:

Error: ESLint configuration in .eslintrc » eslint-config-react-app is invalid:
- Property "overrides" is the wrong type (expected array but got
{"files":["**/*.ts","**/*.tsx"],"parser":"@typescript-eslint/parser","parserOptions":{"ecmaVersion":2018,"sourceType":"module","ecmaFeatures":{"jsx":true},"warnOnUnsupportedTypeScriptVersion":true},"plugins":["@typescript-eslint"],"rules":{"default-case":"off","no-dupe-class-members":"off","@typescript-eslint/no-angle-bracket-type-assertion":"warn","no-array-constructor":"off","@typescript-eslint/no-array-constructor":"warn","@typescript-eslint/no-namespace":"error","no-unused-vars":"off","@typescript-eslint/no-unused-vars":["warn",{"args":"none","ignoreRestSiblings":true}],"no-useless-constructor":"off","@typescript-eslint/no-useless-constructor":"warn"}}).

@bestori
Copy link
Author

bestori commented Feb 12, 2020

The build fails:

Error: ESLint configuration in .eslintrc » eslint-config-react-app is invalid:

  • Property "overrides" is the wrong type (expected array but got
    {"files":["**/*.ts","**/*.tsx"],"parser":"@typescript-eslint/parser","parserOptions":{"ecmaVersion":2018,"sourceType":"module","ecmaFeatures":{"jsx":true},"warnOnUnsupportedTypeScriptVersion":true},"plugins":["@typescript-eslint"],"rules":{"default-case":"off","no-dupe-class-members":"off","@typescript-eslint/no-angle-bracket-type-assertion":"warn","no-array-constructor":"off","@typescript-eslint/no-array-constructor":"warn","@typescript-eslint/no-namespace":"error","no-unused-vars":"off","@typescript-eslint/no-unused-vars":["warn",{"args":"none","ignoreRestSiblings":true}],"no-useless-constructor":"off","@typescript-eslint/no-useless-constructor":"warn"}}).

Indeed. Any ideas? @fzaninotto

@fzaninotto
Copy link
Member

No, sorry.

@bestori
Copy link
Author

bestori commented Feb 12, 2020

No, sorry.

Short blanket facebook/create-react-app#7284

@WiXSL
Copy link
Contributor

WiXSL commented Mar 10, 2020

@bestori,
Upgrading eslint-config-react-app to version 5.2.0 should solve it (current ra version: v4.0.1).
This was fixed in version 3.1.0 of create-react-app when they upgraded to ESLint v6.

facebook/create-react-app#7219

create-react-app Changelog:
https://github.com/facebook/create-react-app/releases?after=eslint-config-react-app%405.0.1

package.json Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
yarn.lock Show resolved Hide resolved
@WiXSL WiXSL mentioned this pull request Jul 15, 2020
@Luwangel
Copy link
Contributor

Thanks for contributing. But it has been already fixed by #5055. It will be part of the next major release (probably v3.8.0).

@Luwangel Luwangel closed this Jul 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants