Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix eslint version #5055

Merged
merged 2 commits into from
Jul 17, 2020
Merged

Fix eslint version #5055

merged 2 commits into from
Jul 17, 2020

Conversation

WiXSL
Copy link
Contributor

@WiXSL WiXSL commented Jul 15, 2020

More info here: #4411

Luwangel
Luwangel reviewed Jul 16, 2020
View reviewed changes
Copy link
Contributor

@Luwangel Luwangel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 🙏

yarn.lock Outdated Show resolved Hide resolved
@WiXSL
Copy link
Contributor Author

WiXSL commented Jul 16, 2020 •
edited
Loading

In the last commit I set @typescript-eslint/eslint-plugin and @typescript-eslint/parser to version 2.10.0 (expected by react-scripts v3.0.0 at the demo and tutorial projects) in order to pass tests and to fix the following warning running the linter. It also improves on yarn.lock deduplication.

WARNING: You are currently running a version of TypeScript which is not officially supported by typescript-estree.
You may find that it works just fine, or you may not.
SUPPORTED TYPESCRIPT VERSIONS: >=3.2.1 <3.6.0
YOUR TYPESCRIPT VERSION: 3.7.5
Please only submit bug reports when using the officially supported version.

@Luwangel Luwangel added the RFR Ready For Review label Jul 17, 2020
@Luwangel Luwangel changed the title Fix eslint version. Fix eslint version Jul 17, 2020
@Luwangel Luwangel merged commit 6438646 into marmelab:next Jul 17, 2020
@Luwangel Luwangel added this to the 3.8.0 milestone Jul 17, 2020
@WiXSL WiXSL deleted the fix-eslint-version branch July 17, 2020 10:36
@Luwangel Luwangel mentioned this pull request Jul 22, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Luwangel Luwangel Luwangel left review comments

Assignees
No one assigned
Labels
RFR Ready For Review
Projects
None yet
Milestone
3.8.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@WiXSL @Luwangel