Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port assert to expect in tests. #4941

Merged
merged 5 commits into from
Jun 15, 2020
Merged

Conversation

WiXSL
Copy link
Contributor

@WiXSL WiXSL commented Jun 14, 2020

No description provided.

Copy link
Contributor

@djhi djhi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice :)

Copy link
Member

@fzaninotto fzaninotto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

packages/ra-core/src/dataProvider/fetch.spec.ts Outdated Show resolved Hide resolved
packages/ra-core/src/reducer/admin/notifications.spec.ts Outdated Show resolved Hide resolved
packages/ra-core/src/reducer/admin/ui.spec.ts Outdated Show resolved Hide resolved
@WiXSL WiXSL requested a review from fzaninotto June 15, 2020 15:16
@fzaninotto fzaninotto merged commit 6f33ec6 into marmelab:master Jun 15, 2020
@fzaninotto
Copy link
Member

Thanks!

@fzaninotto fzaninotto added this to the 3.6.2 milestone Jun 15, 2020
@WiXSL WiXSL deleted the assert-to-expect branch June 15, 2020 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants