New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change conditional check for window to use typeof window #4970

Merged

djhi merged 2 commits into marmelab:master from META-DREAMER:ra-data-fakerest/fix-window-check

Jun 23, 2020

Contributor

META-DREAMER commented Jun 22, 2020

This allows the code to run safely in a non-DOM environment

META-DREAMER added 2 commits

June 22, 2020 16:14


          Change conditional check for window to use typeof window

065314f

This allows the code to run safely in a non-DOM environment


          Add check for typeof window in createAdminStore

META-DREAMER added a commit to sourcecred/sourcecred that referenced this pull request


          Fix failing react-admin build

c37cbb9

This mocks out the testing-library modules which were causing issues in the frontend build and adds temporary
patches on postinstall for the other problematic react-admin libraries. We can remove the patches once they merge
the PR that fixes this upstream: marmelab/react-admin#4970

Test Plan: Run yarn start --instance <instance location> to ensure the frontend builds without errors

djhi approved these changes

View reviewed changes

Contributor

djhi left a comment

Thanks!

djhi added this to the 3.6.2 milestone

djhi merged commit 626412c into marmelab:master

topocount pushed a commit to sourcecred/sourcecred that referenced this pull request


          Fix failing react-admin build

This mocks out the testing-library modules which were causing issues in the frontend build and adds temporary
patches on postinstall for the other problematic react-admin libraries. We can remove the patches once they merge
the PR that fixes this upstream: marmelab/react-admin#4970

Test Plan: Run yarn start --instance <instance location> to ensure the frontend builds without errors

topocount pushed a commit to sourcecred/sourcecred that referenced this pull request


          Fix failing react-admin build

ec45580

This mocks out the testing-library modules which were causing issues in the frontend build and adds temporary
patches on postinstall for the other problematic react-admin libraries. We can remove the patches once they merge
the PR that fixes this upstream: marmelab/react-admin#4970

Test Plan: Run yarn start --instance <instance location> to ensure the frontend builds without errors

topocount pushed a commit to sourcecred/sourcecred that referenced this pull request


          Fix failing react-admin build

5e2ed2b

This mocks out the testing-library modules which were causing issues in the frontend build and adds temporary
patches on postinstall for the other problematic react-admin libraries. We can remove the patches once they merge
the PR that fixes this upstream: marmelab/react-admin#4970

Test Plan: Run yarn start --instance <instance location> to ensure the frontend builds without errors

META-DREAMER added a commit to sourcecred/sourcecred that referenced this pull request


          Remove react-admin patches

5d1f255

React admin merged my PR that fixes the issues with window (marmelab/react-admin#4970),
so we no longer need these patches since the issue is addressed upstream now.

TestPlan: Ensure that the site builds and runs without "window is not defined" errors

topocount pushed a commit to sourcecred/sourcecred that referenced this pull request


          Remove react-admin patches

5db5300

React admin merged my PR that fixes the issues with window (marmelab/react-admin#4970),
so we no longer need these patches since the issue is addressed upstream now.

TestPlan: Ensure that the site builds and runs without "window is not defined" errors

topocount pushed a commit to sourcecred/sourcecred that referenced this pull request


          Remove react-admin patches

da30b46

React admin merged my PR that fixes the issues with window (marmelab/react-admin#4970),
so we no longer need these patches since the issue is addressed upstream now.

TestPlan: Ensure that the site builds and runs without "window is not defined" errors

topocount pushed a commit to sourcecred/sourcecred that referenced this pull request


          Fix failing react-admin build

c19f9f3

This mocks out the testing-library modules which were causing issues in the frontend build and adds temporary
patches on postinstall for the other problematic react-admin libraries. We can remove the patches once they merge
the PR that fixes this upstream: marmelab/react-admin#4970

Test Plan: Run yarn start --instance <instance location> to ensure the frontend builds without errors

topocount pushed a commit to sourcecred/sourcecred that referenced this pull request


          Remove react-admin patches

React admin merged my PR that fixes the issues with window (marmelab/react-admin#4970),
so we no longer need these patches since the issue is addressed upstream now.

TestPlan: Ensure that the site builds and runs without "window is not defined" errors

topocount pushed a commit to sourcecred/sourcecred that referenced this pull request


          Fix failing react-admin build

114839e

This mocks out the testing-library modules which were causing issues in the frontend build and adds temporary
patches on postinstall for the other problematic react-admin libraries. We can remove the patches once they merge
the PR that fixes this upstream: marmelab/react-admin#4970

Test Plan: Run yarn start --instance <instance location> to ensure the frontend builds without errors

topocount pushed a commit to sourcecred/sourcecred that referenced this pull request


          Remove react-admin patches

51f5a91

React admin merged my PR that fixes the issues with window (marmelab/react-admin#4970),
so we no longer need these patches since the issue is addressed upstream now.

TestPlan: Ensure that the site builds and runs without "window is not defined" errors

topocount pushed a commit to sourcecred/sourcecred that referenced this pull request


          Remove react-admin patches

c058910

React admin merged my PR that fixes the issues with window (marmelab/react-admin#4970),
so we no longer need these patches since the issue is addressed upstream now.

TestPlan: Ensure that the site builds and runs without "window is not defined" errors

topocount pushed a commit to sourcecred/sourcecred that referenced this pull request


          Fix failing react-admin build

418b728

This mocks out the testing-library modules which were causing issues in the frontend build and adds temporary
patches on postinstall for the other problematic react-admin libraries. We can remove the patches once they merge
the PR that fixes this upstream: marmelab/react-admin#4970

Test Plan: Run yarn start --instance <instance location> to ensure the frontend builds without errors

topocount pushed a commit to sourcecred/sourcecred that referenced this pull request


          Remove react-admin patches

20c242d

React admin merged my PR that fixes the issues with window (marmelab/react-admin#4970),
so we no longer need these patches since the issue is addressed upstream now.

TestPlan: Ensure that the site builds and runs without "window is not defined" errors

META-DREAMER added a commit to sourcecred/sourcecred that referenced this pull request


          Remove react-admin patches

7c6fb8a

React admin merged my PR that fixes the issues with window (marmelab/react-admin#4970),
so we no longer need these patches since the issue is addressed upstream now.

TestPlan: Ensure that the site builds and runs without "window is not defined" errors

topocount pushed a commit to sourcecred/sourcecred that referenced this pull request


          Fix failing react-admin build

07a33d7

This mocks out the testing-library modules which were causing issues in the frontend build and adds temporary
patches on postinstall for the other problematic react-admin libraries. We can remove the patches once they merge
the PR that fixes this upstream: marmelab/react-admin#4970

Test Plan: Run yarn start --instance <instance location> to ensure the frontend builds without errors

topocount pushed a commit to sourcecred/sourcecred that referenced this pull request


          Remove react-admin patches

f340f52

React admin merged my PR that fixes the issues with window (marmelab/react-admin#4970),
so we no longer need these patches since the issue is addressed upstream now.

TestPlan: Ensure that the site builds and runs without "window is not defined" errors

topocount pushed a commit to sourcecred/sourcecred that referenced this pull request


          Fix failing react-admin build

4b14821

This mocks out the testing-library modules which were causing issues in the frontend build and adds temporary
patches on postinstall for the other problematic react-admin libraries. We can remove the patches once they merge
the PR that fixes this upstream: marmelab/react-admin#4970

Test Plan: Run yarn start --instance <instance location> to ensure the frontend builds without errors

topocount pushed a commit to sourcecred/sourcecred that referenced this pull request


          Remove react-admin patches

904c223

React admin merged my PR that fixes the issues with window (marmelab/react-admin#4970),
so we no longer need these patches since the issue is addressed upstream now.

TestPlan: Ensure that the site builds and runs without "window is not defined" errors

topocount pushed a commit to sourcecred/sourcecred that referenced this pull request


          Fix failing react-admin build

d53683b

This mocks out the testing-library modules which were causing issues in the frontend build and adds temporary
patches on postinstall for the other problematic react-admin libraries. We can remove the patches once they merge
the PR that fixes this upstream: marmelab/react-admin#4970

Test Plan: Run yarn start --instance <instance location> to ensure the frontend builds without errors

topocount pushed a commit to sourcecred/sourcecred that referenced this pull request


          Remove react-admin patches

c99ccf4

React admin merged my PR that fixes the issues with window (marmelab/react-admin#4970),
so we no longer need these patches since the issue is addressed upstream now.

TestPlan: Ensure that the site builds and runs without "window is not defined" errors

META-DREAMER added a commit to sourcecred/sourcecred that referenced this pull request


          Fix failing react-admin build

6840ea9

This mocks out the testing-library modules which were causing issues in the frontend build and adds temporary
patches on postinstall for the other problematic react-admin libraries. We can remove the patches once they merge
the PR that fixes this upstream: marmelab/react-admin#4970

Test Plan: Run yarn start --instance <instance location> to ensure the frontend builds without errors

META-DREAMER added a commit to sourcecred/sourcecred that referenced this pull request


          Remove react-admin patches

0e8fa00

React admin merged my PR that fixes the issues with window (marmelab/react-admin#4970),
so we no longer need these patches since the issue is addressed upstream now.

TestPlan: Ensure that the site builds and runs without "window is not defined" errors

META-DREAMER added a commit to sourcecred/sourcecred that referenced this pull request


          Setup React Admin frontend (#1888)

* Setup React Admin frontend

This configures ReactAdmin to render as the frontend with a simple "fake data provider".
SSR issues need to be addressed before the UI will be visible

TestPlan: Ensure the frontend builds when running yarn start

* Fix failing react-admin build

This mocks out the testing-library modules which were causing issues in the frontend build and adds temporary
patches on postinstall for the other problematic react-admin libraries. We can remove the patches once they merge
the PR that fixes this upstream: marmelab/react-admin#4970

Test Plan: Run yarn start --instance <instance location> to ensure the frontend builds without errors

* Update history to compatible version

Updates the history package to a version compatible with the React Router v4

Test Plan: Run yarn start --instance <instance location> and ensure the
 React Admin UI renders and navigation works

* Fix flow errors importing from history package

v4 of the history package updated the import format, updated our usage to match.
More info: https://github.com/ReactTraining/history/blob/845d690c5576c7f55ecbe14babe0092e8e5bc2bb/CHANGES.md#v400-0

TestPlan: Ensure flow check passes

* Add flow types for History and React-Router

Better type safety is always nice to have :)

TestPlan: Ensure versions for typings match installed versions of history and react-router

* remove withAssets and createRelativeHistory

withAssets is no longer needed since we have the Docusaurus site to fulfill those purposes and
our homepage is no longer being generated by this UI.

RelativeHistroy is no longer needed with Router V5 because this version
of the router accepts a `basename` parameter

TestPlan: Ensure that nothing is still using functionality from these two modules

* Update Link component to react-router v5

React router v5 has moved its Link component into a separate package: react-router-dom. This PR
just updates the place we import the Link component for our own internal wrapper around it.

TestPlan: Ensure that our Link component is still functional

* Remove react-admin patches

React admin merged my PR that fixes the issues with window (marmelab/react-admin#4970),
so we no longer need these patches since the issue is addressed upstream now.

TestPlan: Ensure that the site builds and runs without "window is not defined" errors

Co-authored-by: Kevin Siegler <kevinsiegler54@gmail.com>

topocount pushed a commit to sourcecred/sourcecred that referenced this pull request


          Fix failing react-admin build

29a86df

This mocks out the testing-library modules which were causing issues in the frontend build and adds temporary
patches on postinstall for the other problematic react-admin libraries. We can remove the patches once they merge
the PR that fixes this upstream: marmelab/react-admin#4970

Test Plan: Run yarn start --instance <instance location> to ensure the frontend builds without errors

topocount pushed a commit to sourcecred/sourcecred that referenced this pull request


          Remove react-admin patches

233117a

React admin merged my PR that fixes the issues with window (marmelab/react-admin#4970),
so we no longer need these patches since the issue is addressed upstream now.

TestPlan: Ensure that the site builds and runs without "window is not defined" errors

topocount pushed a commit to sourcecred/sourcecred that referenced this pull request


          Fix failing react-admin build

f0cad75

This mocks out the testing-library modules which were causing issues in the frontend build and adds temporary
patches on postinstall for the other problematic react-admin libraries. We can remove the patches once they merge
the PR that fixes this upstream: marmelab/react-admin#4970

Test Plan: Run yarn start --instance <instance location> to ensure the frontend builds without errors

topocount pushed a commit to sourcecred/sourcecred that referenced this pull request


          Remove react-admin patches

163ebe7

React admin merged my PR that fixes the issues with window (marmelab/react-admin#4970),
so we no longer need these patches since the issue is addressed upstream now.

TestPlan: Ensure that the site builds and runs without "window is not defined" errors

topocount pushed a commit to sourcecred/sourcecred that referenced this pull request


          Fix failing react-admin build

281e0e7

This mocks out the testing-library modules which were causing issues in the frontend build and adds temporary
patches on postinstall for the other problematic react-admin libraries. We can remove the patches once they merge
the PR that fixes this upstream: marmelab/react-admin#4970

Test Plan: Run yarn start --instance <instance location> to ensure the frontend builds without errors

topocount pushed a commit to sourcecred/sourcecred that referenced this pull request


          Remove react-admin patches

4c2630b

React admin merged my PR that fixes the issues with window (marmelab/react-admin#4970),
so we no longer need these patches since the issue is addressed upstream now.

TestPlan: Ensure that the site builds and runs without "window is not defined" errors

topocount pushed a commit to sourcecred/sourcecred that referenced this pull request


          Fix failing react-admin build

d8d7ec3

This mocks out the testing-library modules which were causing issues in the frontend build and adds temporary
patches on postinstall for the other problematic react-admin libraries. We can remove the patches once they merge
the PR that fixes this upstream: marmelab/react-admin#4970

Test Plan: Run yarn start --instance <instance location> to ensure the frontend builds without errors

topocount pushed a commit to sourcecred/sourcecred that referenced this pull request


          Remove react-admin patches

b3950fa

React admin merged my PR that fixes the issues with window (marmelab/react-admin#4970),
so we no longer need these patches since the issue is addressed upstream now.

TestPlan: Ensure that the site builds and runs without "window is not defined" errors

youngkidwarrior pushed a commit to youngkidwarrior/sourcecred that referenced this pull request


          Setup React Admin frontend (sourcecred#1888)

a284941

* Setup React Admin frontend

This configures ReactAdmin to render as the frontend with a simple "fake data provider".
SSR issues need to be addressed before the UI will be visible

TestPlan: Ensure the frontend builds when running yarn start

* Fix failing react-admin build

This mocks out the testing-library modules which were causing issues in the frontend build and adds temporary
patches on postinstall for the other problematic react-admin libraries. We can remove the patches once they merge
the PR that fixes this upstream: marmelab/react-admin#4970

Test Plan: Run yarn start --instance <instance location> to ensure the frontend builds without errors

* Update history to compatible version

Updates the history package to a version compatible with the React Router v4

Test Plan: Run yarn start --instance <instance location> and ensure the
 React Admin UI renders and navigation works

* Fix flow errors importing from history package

v4 of the history package updated the import format, updated our usage to match.
More info: https://github.com/ReactTraining/history/blob/845d690c5576c7f55ecbe14babe0092e8e5bc2bb/CHANGES.md#v400-0

TestPlan: Ensure flow check passes

* Add flow types for History and React-Router

Better type safety is always nice to have :)

TestPlan: Ensure versions for typings match installed versions of history and react-router

* remove withAssets and createRelativeHistory

withAssets is no longer needed since we have the Docusaurus site to fulfill those purposes and
our homepage is no longer being generated by this UI.

RelativeHistroy is no longer needed with Router V5 because this version
of the router accepts a `basename` parameter

TestPlan: Ensure that nothing is still using functionality from these two modules

* Update Link component to react-router v5

React router v5 has moved its Link component into a separate package: react-router-dom. This PR
just updates the place we import the Link component for our own internal wrapper around it.

TestPlan: Ensure that our Link component is still functional

* Remove react-admin patches

React admin merged my PR that fixes the issues with window (marmelab/react-admin#4970),
so we no longer need these patches since the issue is addressed upstream now.

TestPlan: Ensure that the site builds and runs without "window is not defined" errors

Co-authored-by: Kevin Siegler <kevinsiegler54@gmail.com>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet