Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix FilterListItem doesn't appear selected when more than one filter is applied #5644

Conversation

fzaninotto
Copy link
Member

Fixes a regression introduced by #5559

Added unit tests to avoid regressions in the future

Before

filterlistitem_broken

After

filterlistitem

…is applied

Fixes a regression introduced by #5559
Added unit tests to avoid regressions in the future
@fzaninotto fzaninotto added the RFR Ready For Review label Dec 8, 2020
@mjattiot
Copy link
Contributor

mjattiot commented Dec 9, 2020

Indeed our last PR was not properly tested, sorry.
We have introduced a new one #5642 doing the same fix as yours, but yours seems more elegant.
Anyway we also introduce into this #5642 PR some additional improvments to handle nested values in FilterListItem

@djhi djhi added this to the 3.11 milestone Dec 9, 2020
@djhi djhi merged commit bdd0b29 into master Dec 9, 2020
@djhi djhi deleted the Fix-FilterListItem-doesn't-appear-selected-when-more-than-one-filter-is-applied branch December 9, 2020 08:22
mjattiot added a commit to mjattiot/react-admin that referenced this pull request Dec 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
RFR Ready For Review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants