Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce Translatable inputs and fields #5810

Merged
merged 27 commits into from Jan 27, 2021
Merged

Introduce Translatable inputs and fields #5810

merged 27 commits into from Jan 27, 2021

Conversation

djhi
Copy link
Contributor

@djhi djhi commented Jan 22, 2021 •
edited

  • Implementation
  • Integration in simple example
  • Tests
  • Documentation

ra-translatable

@djhi djhi added the WIP Work In Progress label Jan 22, 2021
@djhi djhi added RFR Ready For Review and removed WIP Work In Progress labels Jan 26, 2021
fzaninotto
fzaninotto requested changes Jan 26, 2021
View reviewed changes
Copy link
Member

@fzaninotto fzaninotto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Can't wait to use it!

docs/Fields.md Outdated Show resolved Hide resolved
docs/Fields.md Show resolved Hide resolved
docs/Fields.md Outdated Show resolved Hide resolved
docs/Fields.md Outdated Show resolved Hide resolved
docs/Fields.md Outdated Show resolved Hide resolved
packages/ra-ui-materialui/src/input/TranslatableInputs.tsx Outdated Show resolved Hide resolved
packages/ra-ui-materialui/src/input/TranslatableInputsTab.tsx Outdated Show resolved Hide resolved
packages/ra-ui-materialui/src/input/TranslatableInputsTabContent.tsx Outdated Show resolved Hide resolved
packages/ra-ui-materialui/src/input/TranslatableInputs.tsx Show resolved Hide resolved
packages/ra-ui-materialui/src/field/TranslatableFields.tsx Show resolved Hide resolved
fzaninotto
fzaninotto requested changes Jan 26, 2021
View reviewed changes
Copy link
Member

@fzaninotto fzaninotto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The GitHub linter mentions one remaining warning in your code. Apart from that, it's 💯 !

@fzaninotto fzaninotto merged commit 9bc7ba1 into next Jan 27, 2021
@fzaninotto fzaninotto deleted the translatable branch January 27, 2021 08:28
@fzaninotto fzaninotto added this to the 3.12 milestone Jan 27, 2021
@srosset81 srosset81 mentioned this pull request Jan 30, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fzaninotto fzaninotto fzaninotto approved these changes

Assignees
No one assigned
Labels
RFR Ready For Review
Projects
None yet
Milestone
3.12
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@djhi @fzaninotto