Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix FilterButton throws error if no filters are present #7227

Merged
merged 3 commits into from
Feb 11, 2022

Conversation

WiXSL
Copy link
Contributor

@WiXSL WiXSL commented Feb 10, 2022

Fixes #7026

@WiXSL WiXSL added the RFR Ready For Review label Feb 10, 2022
@WiXSL WiXSL modified the milestones: 4.0.0-alpha.3, v3.19.8 Feb 10, 2022
@fzaninotto
Copy link
Member

As I explained in the linked issue, I don't think this is the right fix.

@vercel vercel bot temporarily deployed to Preview – react-admin-storybook February 11, 2022 11:11 Inactive
@vercel vercel bot temporarily deployed to Preview – react-admin February 11, 2022 11:11 Inactive
@WiXSL WiXSL changed the title [Docs] Fix List actions example Fix FilterButton if no filters are present Feb 11, 2022
@WiXSL WiXSL changed the title Fix FilterButton if no filters are present Fix FilterButton throws error if no filters are present Feb 11, 2022
@vercel vercel bot temporarily deployed to Preview – react-admin-storybook February 11, 2022 14:06 Inactive
@vercel vercel bot temporarily deployed to Preview – react-admin February 11, 2022 14:06 Inactive
@fzaninotto fzaninotto merged commit f7134df into master Feb 11, 2022
@fzaninotto fzaninotto deleted the fix-actions-example branch February 11, 2022 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
RFR Ready For Review
Projects
None yet
2 participants