-
-
Notifications
You must be signed in to change notification settings - Fork 5.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix logout doesn't reset resource registration #7539
Conversation
7b952c7
to
557e95c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can still reproduce the bug described in #7527 locally, in the simple project. Just copy the index.tsx
code of the proposed sandbox to the simple project's index.tsx
After thinking it through, I believe we should unregister resources when unmounting |
I added some tests to cover this. |
I made sure the last test doesn't pass if we don't unregister the resource. The PR is ready for review. |
I've tested it and the ready screen only shows up briefly. I've updated the docs and code to prevent it. |
Co-authored-by: Aníbal Svarcas <WiXSL@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔥
Closes #7527 and #7586